Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI fun - run all test parts always #1916

Merged
merged 2 commits into from
Aug 31, 2023
Merged

More CI fun - run all test parts always #1916

merged 2 commits into from
Aug 31, 2023

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Noticed as I was paying close attention to the slow CI runners, if an earlier section failed then subsection tests would not be ran. We want all tests to be ran, and show what failed. For example, in https://github.com/huggingface/accelerate/actions/runs/6038483640/job/16385348804 the job stopped after the integration tests on multi-gpu because they failed, and then reported that to the slack runner

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan

@muellerzr muellerzr changed the title More CI fun - run all test parts always More CI fun - run all test parts always on nightly specifically Aug 31, 2023
@muellerzr muellerzr changed the title More CI fun - run all test parts always on nightly specifically More CI fun - run all test parts always Aug 31, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 31, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, that's annoying that this requires to be added everywhere. I checked if there is a blanket option to enable this, but fail-fast: false seems to be only for matrix tests.

There is also continue-on-error, which seems to invert the control (put it on the step that is allowed to fail and not on the step that should run despite failure).

Anyway, I think we can also live with this solution. Although, from my understanding, it means that the steps even run if the GH action is cancelled manually, that probably happens rarely enough that we can ignore it.

@muellerzr
Copy link
Collaborator Author

Yep, exactly 😄 There shouldn't be a real reason to cancel them early, but if a need arises then we'll want to do a restructure of these workflows to allow it

@muellerzr muellerzr merged commit 739b135 into main Aug 31, 2023
25 checks passed
@muellerzr muellerzr deleted the more-workflow-stuff branch August 31, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants