Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup dataloader state dict bugs + incorporate load/save_state API #3034

Merged
merged 19 commits into from
Aug 23, 2024
Merged

Fixup dataloader state dict bugs + incorporate load/save_state API #3034

merged 19 commits into from
Aug 23, 2024

Commits on Aug 22, 2024

  1. v1

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f9d914e View commit details
    Browse the repository at this point in the history

  2. More testing, need to try on H100

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    079eba4 View commit details
    Browse the repository at this point in the history

  3. Bigger batch for h100 test

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5515b70 View commit details
    Browse the repository at this point in the history

  4. test tweak

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    aecf440 View commit details
    Browse the repository at this point in the history

  5. Fixup all tests!

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    baa041d View commit details
    Browse the repository at this point in the history

  6. Bookmark

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1e5032e View commit details
    Browse the repository at this point in the history

  7. Fix issues, working now

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    463a045 View commit details
    Browse the repository at this point in the history

  8. rm num samples

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4ec77b5 View commit details
    Browse the repository at this point in the history

  9. Uncomment

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5866951 View commit details
    Browse the repository at this point in the history

  10. Give stateful dl end of dl

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    36a735c View commit details
    Browse the repository at this point in the history

  11. Make skip DL stateful

    @muellerzr
    muellerzr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e0ea50d View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Migrate to update_state_dict

    @muellerzr
    muellerzr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b32f37a View commit details
    Browse the repository at this point in the history

  2. try/finally

    @muellerzr
    muellerzr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    285ab46 View commit details
    Browse the repository at this point in the history

  3. Add comments to test

    @muellerzr
    muellerzr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a2de149 View commit details
    Browse the repository at this point in the history

  4. rm comment

    @muellerzr
    muellerzr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    160d0ee View commit details
    Browse the repository at this point in the history

  5. Document

    @muellerzr
    muellerzr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ff8aefa View commit details
    Browse the repository at this point in the history

  6. refactor out for eventual override

    @muellerzr
    muellerzr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3ca6272 View commit details
    Browse the repository at this point in the history

  7. Doc nit

    @muellerzr
    muellerzr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5ad3091 View commit details
    Browse the repository at this point in the history

  8. Brute force it

    @muellerzr
    muellerzr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2a83d54 View commit details
    Browse the repository at this point in the history