-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bfloat16 for Upsample2D #9480
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Is it possible to add a small test for this? Our CI already has the latest PyTorch.
@sayakpaul For sure, just added a test for bfloat16 by copying over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! @yiyixuxu WDYT?
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Support bfloat16 for Upsample2D. This change is backwards compatible.
Resolves the TODO comment as PyTorch 2.1+ supports bloat16. Referencing the original PyTorch issue:
pytorch/pytorch#86679 (comment)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
CC: @sayakpaul @yiyixuxu