Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the multi-cards support for image_to_text examples #1312

Closed
wants to merge 4 commits into from

Conversation

yuanwu2017
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@yafshar
Copy link
Contributor

yafshar commented Sep 12, 2024

@yuanwu2017 can you update the README? with information for multi cards run

@yafshar
Copy link
Contributor

yafshar commented Sep 12, 2024

I have tried

QUANT_CONFIG=./quantization_config/maxabs_measure.json python ../gaudi_spawn.py --world_size 2 --use_deepspeed run_pipeline.py --model_name_or_path llava-hf/llava-v1.6-mistral-7b-hf --image_path "https://llava-vl.github.io/static/images/view.jpg" --use_hpu_graphs --bf16

and the command is working on your changes and without it. The same as below,

python3 ../gaudi_spawn.py --world_size 2 --use_deepspeed  run_pipeline.py \
    --model_name_or_path llava-hf/llava-v1.6-mistral-7b-hf \
    --use_hpu_graphs \
    --bf16

Can you comment on the PR?

@yuanwu2017
Copy link
Contributor Author

I have tried

QUANT_CONFIG=./quantization_config/maxabs_measure.json python ../gaudi_spawn.py --world_size 2 --use_deepspeed run_pipeline.py --model_name_or_path llava-hf/llava-v1.6-mistral-7b-hf --image_path "https://llava-vl.github.io/static/images/view.jpg" --use_hpu_graphs --bf16

and the command is working on your changes and without it. The same as below,

python3 ../gaudi_spawn.py --world_size 2 --use_deepspeed  run_pipeline.py \
    --model_name_or_path llava-hf/llava-v1.6-mistral-7b-hf \
    --use_hpu_graphs \
    --bf16

Can you comment on the PR?
Yes, it can run without the patch, but it is not in TP mode. That is equivalent to running two separate instances that are not related.

@yuanwu2017
Copy link
Contributor Author

@yuanwu2017 can you update the README? with information for multi cards run

Ok. I will update later.

@yafshar
Copy link
Contributor

yafshar commented Sep 19, 2024

@yuanwu2017 would you please address the comment to wrap up this PR. We want to have it in 1.18 release. Thanks

@yuanwu2017
Copy link
Contributor Author

Updated the README. The PR is ok. Please help to review. @regisss @libinta @yafshar

@libinta
Copy link
Collaborator

libinta commented Nov 1, 2024

@yuanwu2017 it seems we already have multi-card examples now, please check and close the PR.thanks

@yuanwu2017 yuanwu2017 closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants