Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized inference of XGLM model on HPU #1323

Merged
merged 8 commits into from
Nov 12, 2024
Merged

Optimized inference of XGLM model on HPU #1323

merged 8 commits into from
Nov 12, 2024

Conversation

XinyuYe-Intel
Copy link
Contributor

What does this PR do?

Optimized inference of XGLM model on HPU.

Before submitting

  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@XinyuYe-Intel
add readme.
45d4d4c 
Signed-off-by: Ye, Xinyu <[email protected]>
@libinta
Copy link
Collaborator

libinta commented Sep 18, 2024

@XinyuYe-Intel can you provide gaudi2 test on latest 1/17/1.18 docker RUN_SLOW=true GAUDI2_CI test and gaudi1 test result?

@XinyuYe-Intel
Copy link
Contributor Author

@XinyuYe-Intel can you provide gaudi2 test on latest 1/17/1.18 docker RUN_SLOW=true GAUDI2_CI test and gaudi1 test result?

perf on gaudi2 on 1.17.1 with RUN_SLOW=true is as below:
image

For gaudi1, I don't have the machine, so I can't provide the result.

ssarkar2
ssarkar2 reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@ssarkar2 ssarkar2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XinyuYe-Intel could you please resolve the conflicts on this PR, looks good otherwise

@XinyuYe-Intel
Copy link
Contributor Author

@XinyuYe-Intel could you please resolve the conflicts on this PR, looks good otherwise

Resolved conflicts.

@libinta
Copy link
Collaborator

libinta commented Nov 1, 2024

@XinyuYe-Intel can you rebase?

@libinta libinta closed this Nov 1, 2024
@libinta libinta reopened this Nov 12, 2024
@XinyuYe-Intel
Copy link
Contributor Author

Tested this PR on FW 1.18.0
image

@libinta libinta added the run-test Run CI for PRs from external contributors label Nov 12, 2024
@regisss regisss merged commit 7fe7bf8 into huggingface:main Nov 12, 2024
2 of 4 checks passed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssarkar2 ssarkar2 ssarkar2 approved these changes

@regisss regisss regisss approved these changes

@bhargaveede bhargaveede Awaiting requested review from bhargaveede bhargaveede is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

Assignees
No one assigned
Labels
run-test Run CI for PRs from external contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XinyuYe-Intel @libinta @HuggingFaceDocBuilderDev @regisss @ssarkar2