Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix T5 inference performance regression #310

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Fix T5 inference performance regression #310

merged 2 commits into from
Jul 28, 2023

Conversation

libinta
Copy link
Collaborator

@libinta libinta commented Jul 27, 2023

For T5 inference, don't wrap dropout with mark_step as it causes performance issue.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 27, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

regisss
regisss reviewed Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgtm!

Let's just remove the formating changes to the notebook please.

notebooks/AI_HW_Summit_2022.ipynb Outdated Show resolved Hide resolved
@libinta libinta force-pushed the fix_t5_infer_perfregression branch from b62aaf9 to cfc426e Compare July 28, 2023 19:07
regisss
regisss approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisss regisss merged commit abbbaaf into main Jul 28, 2023
8 checks passed
@regisss regisss deleted the fix_t5_infer_perfregression branch July 28, 2023 20:19
schoi-habana pushed a commit that referenced this pull request Aug 10, 2023
@libinta @schoi-habana
Fix T5 inference performance regression (#310)
fcd6803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisss regisss regisss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@libinta @HuggingFaceDocBuilderDev @regisss