Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NormalizedConfig support qwen, baichuan, chatglm #1490

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

changwangss
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Signed-off-by: changwangss <[email protected]>
Signed-off-by: changwangss <[email protected]>
"mixformer-sequential": GPTBigCodeNormalizedTextConfig,
"baichuan": NormalizedTextConfig,
"qwen": NormalizedTextConfig,
"chatglm": NormalizedTextConfig.with_args(num_layers="num_layers"),
Copy link
Collaborator

@echarlaix echarlaix Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the vocab size, shouldn't it be padded_vocab_size for ChatGLM models ?
https://huggingface.co/THUDM/chatglm3-6b/blob/main/config.json#L32

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatglm has 3 models , I find chatglm is vocab_size, but chatglm2&3 is padded_vocab_size,Could you help me deal with this situation? @echarlaix
https://huggingface.co/THUDM/chatglm-6b/blob/main/config.json#L27

@changwangss changwangss closed this Jan 8, 2024
@changwangss
Copy link
Contributor Author

Phi, Mixtral has been added to transformers, so add the Phi and Mixtral with #1625 first.
chatglm will add it again when huggingface/transformers#27883 ready.

@changwangss changwangss reopened this Feb 27, 2024
@changwangss changwangss changed the title add NormalizedConfig support qwen, baichuan, chatglm, mixformer-sequential add NormalizedConfig support qwen, baichuan, chatglm Feb 27, 2024
@@ -262,6 +262,11 @@ class NormalizedConfigManager:
"whisper": WhisperLikeNormalizedTextConfig,
"xlm-roberta": NormalizedTextConfig,
"yolos": NormalizedVisionConfig,
"mpt": MPTNormalizedTextConfig,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mpt is already in the list.

Comment on lines +266 to +268
"baichuan": NormalizedTextConfig,
"qwen": NormalizedTextConfig,
"chatglm": NormalizedTextConfig.with_args(num_layers="num_layers"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qwen2 is now available in transformers.

baichuan and chatglm are not.

@fxmarty fxmarty requested a review from echarlaix February 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants