Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the exllama on all non-cuda devices. #2003

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

yuanwu2017
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

1. Disable the exllama on all non-cuda devices.
2. Don't raise the error when running on non-cuda device.

Signed-off-by: yuanwu <[email protected]>
Signed-off-by: yuanwu <[email protected]>
@yuanwu2017 yuanwu2017 marked this pull request as draft August 31, 2024 04:18
Signed-off-by: yuanwu <[email protected]>
@yao-matrix
Copy link

@IlyasMoutawwakil , could you help review? This PR is to disable exllama on non-cuda devices, since other devices don't support it yet, this will enable devices like intel habana can work w/ autogptq. The one open is: do we need add rocm into SUPPORT_EXLLAMA_DEVICES, since the exllama says "it's theoretically supported but not validated", could you share your insights?

@IlyasMoutawwakil
Copy link
Member

@yao-matrix rocm is registered as cuda so that shouldn't be an issue, I think there's no need for a list of supported devices as exllama is written in cuda and will probably on work on cuda/hip/rocm machines, that should simplify the PR.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @yuanwu2017 ! LGTM !

yuanwu2017 and others added 4 commits September 10, 2024 13:43
Co-authored-by: Ilyas Moutawwakil <[email protected]>
Co-authored-by: Ilyas Moutawwakil <[email protected]>
Co-authored-by: Ilyas Moutawwakil <[email protected]>
Co-authored-by: Ilyas Moutawwakil <[email protected]>
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil
Copy link
Member

@yao-matrix can you run make style please

@yuanwu2017
Copy link
Contributor Author

@IlyasMoutawwakil The error is not related with the patch. Please help to merge it.

@IlyasMoutawwakil IlyasMoutawwakil merged commit 2179d33 into huggingface:main Sep 18, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants