Cleanup Vertex + Chat #2553
Open
Cleanup Vertex + Chat #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarobartt
reviewed
Sep 24, 2024
| pub(crate) struct VertexChat { | ||
| messages: Vec<Message>, | ||
| // Messages is ignored there. | ||
| parameters: VertexParameters, |
There was a problem hiding this comment.
Shouldn't this be Option<VertexParameters>, how is the following payload handled?
{"intances": [{"messages": [{"role": "user", "content": "What's Deep Learning?"}]}]}
Thanks in advance!
There was a problem hiding this comment.
Good point ! Fixed it and added the test
alvarobartt
reviewed
Sep 24, 2024
| use crate::{Message, MessageContent}; | ||
|
|
||
| #[test] | ||
| fn vertex_deserialization() { |
There was a problem hiding this comment.
Can we add a test when parameters is not provided too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.