Switch from fbgemm-gpu w8a8 scaled matmul to vLLM/marlin-kernels #2688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Performance and accuracy of these kernels are on par (tested with Llama 70B and 405B). Removes a dependency and resolves some stability issues we have been seeing.
Two test snapshots had to be changed. It seems like the perturbations come from switching from
bfloat16
(which was the only dtype supported by fbgemm FP8 quantization) tofloat16
which is our default dtype for Llama (even though recent Llama checkpoints arebfloat16
).I added an environment variable
USE_CUTLASS_W8A
to force use of the cutlass kernels on compute capability 8. The question why we use FP8-Marlin on compute capability 8.9 comes up occasionally (because it's faster and probably more accurate because it's in FP16), so this is a backdoor to use W8A8 on 8.9 in case somebody really wants it.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.