Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt publication card to handle missing URLs #1017

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

maiani
Copy link
Contributor

@maiani maiani commented Dec 13, 2024

Description

This pull request enhances the publication card to improve its handling of missing URLs for authors and publications.

Key changes include:

  • Conditional Link Handling: The href parameter is completely removed from the a tags when no URL is available.
  • Style Update: Underlines are applied only to elements that contain active links.
  • Button Visibility: The Details button is hidden when no URL is provided for the paper.

These updates ensure a cleaner, more intuitive user interface and prevent confusion caused by non-functional links or buttons.

Sorry for the duplicate pull request.

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit 82b08cc
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/675c72929bc03f0008d6f925
😎 Deploy Preview https://deploy-preview-1017--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maiani

@hossainemruz hossainemruz added the enhancement New feature or request label Dec 19, 2024
@hossainemruz hossainemruz merged commit 047bb51 into hugo-toha:main Dec 19, 2024
15 of 19 checks passed
@maiani maiani deleted the publications branch December 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants