fix: allow loading gzipped fixtures #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a file that ends in `.gz`, `sirv` will set the `Content-Encoding` header to `gzip` which means browsers will unzip the content before handing it back to `fetch` or `XMLHttpRequest`. This PR adds a workaround to the asset server that sets the header to a garbage value if a file ending in `.gz` has been requested. It's necessary to use a garbage value because `sirv` will only set the header if it's not been set already, so we can't simply delete it. Refs: lukeed/sirv#158 Refs: ipfs/aegir#1462
hugomrdias
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When loading a file that ends in
.gz,sirvwill set theContent-Encodingheader togzipwhich means browsers will unzip the content before handing it back tofetchorXMLHttpRequest.This PR adds a workaround to the asset server that sets the header to a garbage value if a file ending in
.gzhas been requested.It's necessary to use a garbage value because
sirvsets the headers after thesetHeadersfunction passed to it's config has been invoked, and it will only not set the header if one has been set already.Link to issue
loadFixturesincorrectly alters bytes in the browser ipfs/aegir#1462Type of change
Please delete options that are not relevant.