Skip to content

Commit

Permalink
Update CI to Ubuntu 24.04.
Browse files Browse the repository at this point in the history
  • Loading branch information
hugopl committed Jun 28, 2024
1 parent 7723aa0 commit 4fc2e45
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 14 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
tests:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Install package dependencies
run: sudo apt-get install gobject-introspection libgirepository1.0-dev
Expand All @@ -23,6 +23,6 @@ jobs:
- name: Linter
run: crystal tool format --check
- name: Run tests
run: G_DEBUG=fatal-warnings RSPEC_OPTS="-v --order=random" make oldlibs-test
run: G_DEBUG=fatal-warnings RSPEC_OPTS="-v --order=random" make test
- name: Run tests with -Ddebugmemory
run: G_DEBUG=fatal-warnings OLD_LIBS=1 ./bin/spec -Ddebugmemory -v --order=random
run: G_DEBUG=fatal-warnings ./bin/spec -Ddebugmemory -v --order=random
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
test: test-binding
./bin/spec $(RSPEC_OPTS)

oldlibs-test: test-binding
OLD_LIBS=1 ./bin/spec $(RSPEC_OPTS)

generator:
shards build --error-trace

Expand Down
14 changes: 6 additions & 8 deletions spec/properties_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,11 @@ describe "GObject properties" do
subject.str_list.should eq(%w(let go))
end

{% unless env("OLD_LIBS") %}
context "when of boolean type" do
it "transform `is_prop` to `is_prop?`" do
subject = Test::Subject.new(boolean: true)
subject.is_bool?.should eq(true)
subject.boolean?.should eq(true)
end
context "when of boolean type" do
it "transform `is_prop` to `is_prop?`" do
subject = Test::Subject.new(boolean: true)
subject.is_bool?.should eq(true)
subject.boolean?.should eq(true)
end
{% end %}
end
end

0 comments on commit 4fc2e45

Please sign in to comment.