Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration support evolves - 1/n #13

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Binlogo
Copy link
Contributor

@Binlogo Binlogo commented Jun 25, 2024

Roadmap: #7 (comment)

  • Evolve configuration:
    • 👉 Support standalone xcframework.toml config file together with [package.metadata.xcframework] table
    • Support pre-build hooks. e.g: to generate headers (.h) or module map files.
    • Support custom-build options. e.g: to allow running user-defined build jobs.
  • legacy(v1) config format seamless support.

@Binlogo Binlogo changed the title Configuration support evolves - n Configuration support evolves - 1/n Jun 25, 2024
@akesson
Copy link
Member

akesson commented Jun 25, 2024

I'm already looking forwards to this PR 😄

One thing: I don't think the "legacy config format seamless support" is really important. The project is in alpha which basically signals that these types of changes are likely. Instead focus on making changes that makes sense

@Binlogo
Copy link
Contributor Author

Binlogo commented Jun 25, 2024

I'm already looking forwards to this PR 😄

Thanks for your encouraging words. I will continue working on this PR during my spare time until it's ready. If you have any concerns or suggestions, please feel free to share them.

One thing: I don't think the "legacy config format seamless support" is really important. The project is in alpha which basically signals that these types of changes are likely. Instead focus on making changes that makes sense

Agree, this is a lower priority, but for "legacy config support" or in other words, "the simple configuration in its early stages and straightforward use case", I'm considering extensibility and simplicity balance.

@Binlogo Binlogo force-pushed the feat/primer-core-config branch 4 times, most recently from 4581599 to 6879645 Compare June 27, 2024 15:50
@akesson
Copy link
Member

akesson commented Sep 20, 2024

Hey @Binlogo. Do you think you'll keep working on this? I'll do some changes myself now but they'll surely conflict with the ones in this PR.

@Binlogo
Copy link
Contributor Author

Binlogo commented Sep 20, 2024

Hey @Binlogo. Do you think you'll keep working on this? I'll do some changes myself now but they'll surely conflict with the ones in this PR.

Oh, I almost forgot. 😶 My focus has shifted, so I might return to this later. For now, I won't be able to continue in the short term. Please go ahead with your changes, and I'll handle any conflicts or redo them if necessary.

@akesson
Copy link
Member

akesson commented Sep 20, 2024

Sure. You are welcome back anytime you want 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants