Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom assignee column #154

Merged
merged 6 commits into from
Jun 2, 2021
Merged

add custom assignee column #154

merged 6 commits into from
Jun 2, 2021

Conversation

jazzsequence
Copy link
Contributor

Adds an Assignees column

  • Updated changelog
  • Updated version number in package.json and plugin.php file with appropriate MAJOR.MINOR.PATCH change

@jazzsequence jazzsequence self-assigned this May 28, 2021
@jazzsequence
Copy link
Contributor Author

Note: Linter is failing due to an unrelated apparent issue with /admin/package.json -- documented here

Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of improvements to make on the column code, and a suggested change to only add the column for post types that support editorial comments. I know it wouldn't have been strictly clear that those 2 things are functionally bound together right now because of the post lists filter. Might be good to fix that too as part of this PR.

admin/admin.php Outdated Show resolved Hide resolved
admin/admin.php Outdated Show resolved Hide resolved
admin/admin.php Outdated Show resolved Hide resolved
Chris Reynolds and others added 3 commits June 1, 2021 11:04
use array_map and an anonymous function to build the links for assignees & implode to save the group to a variable before echoing the whole string.
Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidy, thanks @jazzsequence 👍

@roborourke roborourke merged commit a6cc1ab into master Jun 2, 2021
@roborourke roborourke deleted the 39-assignment-in-post-list branch June 2, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants