Add HTTP handler #137
Open
Add HTTP handler #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows use via API Gateway in a web form.
mikeselander
suggested changes
May 29, 2020
src/http.js
Outdated
| version: 'inherit', | ||
| }, | ||
| stylelint: { | ||
| enabled: false, |
There was a problem hiding this comment.
Since there's a CSS button on the Make site, we'll need to enable stylelint here.
There was a problem hiding this comment.
duh! I copied this from config.js but that was pre-merge!
|
|
||
| // Then, prepare the linters. | ||
| const config = { | ||
| version: data.get( 'version' ) || 'latest', |
There was a problem hiding this comment.
This is a future enhancement, but it would be really great to be able to push up a "future" version with the unreleased changes and check against them before they're released. I think it would help us in testing and potentially help projects with checking some code without having to update a. whole project.
There was a problem hiding this comment.
Should be possible already I think?
| let baseDir = dir; | ||
| while ( fnParts.length > 1 ) { | ||
| const nextPart = fnParts.shift(); | ||
| if ( nextPart === '..' || nextPart === '.' ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows use via API Gateway in a web form, powering https://make.hmn.md/lint-check/
Requires API Gateway reconfiguration; hm-linter-development has that reconfiguration, but hm-linter does not yet. (Also, I've already deployed this to hm-linter-development.)
Sidenote: I spent a few hours trying to get API Gateway testing locally, and could not work it out, I don't think it's really possible. For testing this, unfortunately the best way is to use hm-linter-development so you get the actual event object from API Gateway. 😞