Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add support for VEML7700 (closes #726) #1090

Closed
wants to merge 21 commits into from

Conversation

szampardi
Copy link

@szampardi szampardi commented Oct 17, 2024

Solved issues and/or description of the change

#726
...

Manual test

  • OS and Version (Win/Mac/Linux):
  • archlinuxarm 6.6.56-1-rpi (rpi0w 2)
  • Adaptor(s) and/or driver(s):
  • rpi
  • i2c
    ...

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

If this is a new driver or adaptor:

  • I have added the name to the corresponding README.md
  • I have added an example to see how to setup and use it
  • I have checked or build at least my new example (e.g. by run make examples_check)

If this is a PR for release:

  • The PR's target branch is 'hybridgroup:release'
  • I have adjusted the CHANGELOG.md (or already prepared and will be merged as soon as possible)

@szampardi
Copy link
Author

@gen2thomas saw that.. luckily I happen to be on semi-vacation so will check the errors out tomorrow morning :D

@gen2thomas
Copy link
Collaborator

@szampardi no worry - after some month of nearly do nothing for gobot I determine also problems with CircleCI, at least on the UI. Hopefully I can solve this or it does not happen on server.

@gen2thomas
Copy link
Collaborator

Hi @szampardi , please rebase to dev branch - the CI checks are working.

Thanks Thomas

@szampardi
Copy link
Author

please rebase to dev branch

well that didn't go as expected :D

@gen2thomas
Copy link
Collaborator

From the commit history I think it was a merge not a rebase. After an rebase your commit should be the last (newest) in the history.

@szampardi szampardi closed this Nov 7, 2024
@szampardi szampardi deleted the patch-1 branch November 7, 2024 19:48
@gen2thomas
Copy link
Collaborator

superseded by #1099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants