-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to snakemake 8 #71
base: develop
Are you sure you want to change the base?
Conversation
Something seems to go wrong with the copy rules when running the integration test. I get the following traceback:
My guess is that something about the rule function signature has changed in snakemake 8 and that the corresponding update needs to be made to |
Found a post on stackoverflow that claims that you can use a different syntax for generating dynamic rules, and I imagine that this would make things much more portable. Really cool if that works! Example: config = {'person1': 'Amy', 'person2': 'Bruce'}
def create_rule(thiskey, thisperson):
rule:
name: f"{thisperson}s_rule"
output: f"{thiskey}.txt"
run:
print(f'\n{thiskey} is called {thisperson}!\n')
# Generate rules
for thiskey, thisperson in config.items():
create_rule(thiskey, thisperson)
rule people:
input: [this + '.txt' for this in config.keys()] |
This PR:
(If this is a release PR, no need to add following. Leave this part empty)
(Use the following lines to create a PR text body. Make sure to remove all non-relevant one after you're done)
(Repeat each field as many times as necessary)
Added: for new features.
Changed: for changes in existing functionality.
Deprecated: for soon-to-be removed features.
Removed: for now removed features.
Fixed: for any bug fixes.
Security: in case of vulnerabilities.
Review and tests:
CHANGELOG.md
is updated