feat: General report chls #72
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is something that is needed in order to correctly resolve relative paths in the config. It is possible that this could be handled in a more automated way, for example by looking at the output files of the pipeline. This works as a start.
This is a start. All the other types should be implemented, and proper unit tests should be added for the script generating the report. As a consequence I might have to make things a bit more granular in order for things to be easily testable.
One thing I have to do here is to check the URL and if it is a path to a local file, add the relative redirect needed in order to resolve the path properly.
This also adds a unit test for the table validation function.
jonca79
commented
Jul 1, 2024
| __license__ = "GPL-3" | ||
|
|
||
|
|
||
| rule general_json_report: |
There was a problem hiding this comment.
This rule has no documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
(If this is a release PR, no need to add following. Leave this part empty)
(Use the following lines to create a PR text body. Make sure to remove all non-relevant one after you're done)
(Repeat each field as many times as necessary)
Added: for new features.
Changed: for changes in existing functionality.
Deprecated: for soon-to-be removed features.
Removed: for now removed features.
Fixed: for any bug fixes.
Security: in case of vulnerabilities.
Review and tests:
CHANGELOG.mdis updated