-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge hydro-project/hydroflow-template into this repo, for #1314 #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unpins the hydroflow version as well
* Update rust-toolchain.toml "nightly" is too unspecific. It matches older incompatible compiler versions. We need to precisely define the compiler version. * add missing toolchain components --------- Co-authored-by: zzlk <[email protected]>
* add basic test case * add ci test instead of in-code test * fix ci * test negative case * remove negative test case
remove unnecessary unwrap() to match`server.rs`.
* compatibility * touch --------- Co-authored-by: Mingwei Samuel <[email protected]>
1. Default server address, so you don't have to copy an address around when starting multiple clients to test a full star network configuration. 2. Help messages for all the arguments. 3. More hand-holding documentation, mostly condensed from the [first networking chapter](https://hydro.run/docs/hydroflow/quickstart/example_7_echo_server) 4. Updated README.md to provide more runnable commands.
MingweiSamuel
added a commit
that referenced
this pull request
Jul 15, 2024
MingweiSamuel
added a commit
that referenced
this pull request
Jul 15, 2024
jhellerstein
pushed a commit
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.