Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(hydroflow_plus): update docs for hydroflow plus, pull code from template for first two examples #1012 #1318

Merged
merged 1 commit into from
Jun 25, 2024
Merged

docs(hydroflow_plus): update docs for hydroflow plus, pull code from template for first two examples #1012 #1318

merged 1 commit into from
Jun 25, 2024

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Jun 24, 2024 •
edited
Loading

Also fix a bug in docs/src/util.ts:getLines() that would cut off the beginning of lines

shadaj
shadaj approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be at cool if at some point we can have commented markers in the code for different snippets so line numbers don't go out of sync.

@MingweiSamuel
Copy link
Member Author

Would be at cool if at some point we can have commented markers in the code for different snippets so line numbers don't go out of sync.

Yeah actually exactly what I was thinking...

@MingweiSamuel MingweiSamuel mentioned this pull request Jun 25, 2024
Open
@MingweiSamuel MingweiSamuel merged commit 8eb8aa1 into hydro-project:main Jun 25, 2024
14 checks passed
@MingweiSamuel MingweiSamuel deleted the update-hfp-docs branch June 25, 2024 14:56
@MingweiSamuel MingweiSamuel mentioned this pull request Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MingweiSamuel @shadaj