Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hydro_deploy): simplify persist_pullup code #1455

Merged
merged 2 commits into from
Sep 23, 2024
Merged

refactor(hydro_deploy): simplify persist_pullup code #1455

merged 2 commits into from
Sep 23, 2024

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Sep 17, 2024 •
edited
Loading

Instead of matching on &mut and juggling ownership, instead match on the owned node and always replaced *node = new_node (sometimes itself)

@MingweiSamuel MingweiSamuel marked this pull request as ready for review September 17, 2024 17:57
shadaj
shadaj approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we should still be fine in terms of stack usage because we still use transform_bottom_up here.

@MingweiSamuel MingweiSamuel merged commit 1b18b35 into hydro-project:main Sep 23, 2024
13 checks passed
@MingweiSamuel MingweiSamuel deleted the persist-pullup branch September 23, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MingweiSamuel @shadaj