Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hydroflow_plus): add missing sample_every for singletons #1461

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

shadaj
Copy link
Member

@shadaj shadaj commented Sep 23, 2024

Discovered during a live-coding demo, we only had it for optionals before.

Discovered during a live-coding demo, we only had it for optionals before.
Copy link

cloudflare-workers-and-pages bot commented Sep 23, 2024

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: de05bf1
Status: ✅  Deploy successful!
Preview URL: https://c0f6834d.hydroflow.pages.dev
Branch Preview URL: https://pr1461.hydroflow.pages.dev

View logs

Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a duplicate sample_every for reduce vs fold somewhere else?

@shadaj
Copy link
Member Author

shadaj commented Sep 23, 2024

Is there a duplicate sample_every for reduce vs fold somewhere else?

Yeah, there is an identical one for Optional, which is used for reduce.

@shadaj shadaj merged commit d4320e3 into main Sep 23, 2024
14 checks passed
@shadaj shadaj deleted the pr1461 branch September 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants