fix(hydroflow_plus): adjust default features to allow compilation to musl targets #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
c6107f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96063739.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1464.hydroflow.pages.dev |
shadaj
commented
Sep 23, 2024
| @@ -16,7 +16,4 @@ | |||
| "files.watcherExclude": { | |||
| "**/target": true | |||
| }, | |||
| "rust-analyzer.cargo.features": [ | |||
There was a problem hiding this comment.
Latest Rust Analyzer update complains about python not being a recognized feature on some crates.
davidchuyaya
approved these changes
Sep 23, 2024
…musl targets Previously, the default `deploy` feature would pull in Hydro Deploy and its transitive native dependencies. Also sets up `examples/paxos.rs` with CLI flags to deploy to GCP.
MingweiSamuel
approved these changes
Sep 24, 2024
When we deploy to GCP (or any remote host), we compile to musl to avoid glibc conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default
deployfeature would pull in Hydro Deploy and its transitive native dependencies.Also sets up
examples/paxos.rswith CLI flags to deploy to GCP.