feat: add lattice_reduce and lattice_fold #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzlk
commented
Jun 30, 2023
MingweiSamuel
approved these changes
Jun 30, 2023
| let lat_type = &type_args[0]; | ||
|
|
||
| let arguments = parse_quote_spanned! {lat_type.span()=> // Uses `lat_type.span()`! | ||
| <#lat_type>::default(), #root::lattices::Merge::merge_owned |
There was a problem hiding this comment.
<#lat_type as ::std::default::Default>::default()
There was a problem hiding this comment.
hmm, I wonder what is the difference in this case?
nickjiang2378
pushed a commit
to nickjiang2378/hydroflow
that referenced
this pull request
Jan 24, 2024
* feat: add lattice_reduce and lattice_fold * address comments * simplify lattice fold a bit * address comments
nickjiang2378
pushed a commit
to nickjiang2378/hydroflow
that referenced
this pull request
Jan 25, 2024
* feat: add lattice_reduce and lattice_fold * address comments * simplify lattice fold a bit * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #752