-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pooch integration, mark online tests, better handle online-dependent documentation, distributed testing #212
Conversation
…ports, better typing in major functions
I need to convert the exiting pooch calls to the new system, but before that, the pooch-based setup code causing errors at the moment needs to be converted to pytest fixtures. Will tackle that tomorrow. |
@Zeitsperre I have implemented the fix for the GIS module here : #213 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work, thanks for improving the quality of the codebase!
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll see if the GIS notebook passes. Otherwise, we might need to run the outputs locally as was done before.
(Note that I didn't include that notebook in #211, since it wasn't run by RtD).
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
online
).pytest-xdist
to the development dependencies.pooch
registry for verifying file integrity when fetching testing data.Does this PR introduce a breaking change?
Yes.
pytest-xdist
is now a development dependency. By default, it is not being used, but it can be enabled by providing positional arguments to thepytest
call.Other information:
I've copied and slightly improved upon the new testing data system currently in #175. I'll handle the merge of the changes to there, but this current system is nearing finalization. The last thing that I'm waiting on are some changes from @RondeauG to
xhydro-testdata
so that I can make a dated tag that will become the default testing data branch forxhydro
(updated whenever there are additions toxhydro-testdata
). This will help prevent breakages from a movingmain
branch over there.