Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicators as a module #226

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Indicators as a module #226

merged 3 commits into from
Nov 6, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Nov 6, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Makes indicators into a module. Moves pmp.py into it.

Does this PR introduce a breaking change?

  • The PMP functions are now accessed through xh.indicators.pmp rather than xh.pmp.

Other information:

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added notebooks Run tests against notebooks docs labels Nov 6, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Nov 6, 2024
@RondeauG RondeauG merged commit 23eb0f1 into main Nov 6, 2024
26 checks passed
@RondeauG RondeauG deleted the ind_module branch November 6, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospinajulian ospinajulian ospinajulian approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs notebooks Run tests against notebooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make indicators into a module and move PMP into it
2 participants
@RondeauG @ospinajulian