Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Upgrade to Ratpack v1.5.4 #62

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Upgrade to Ratpack v1.5.4 #62

wants to merge 5 commits into from

Conversation

hyleung
Copy link
Owner

@hyleung hyleung commented May 26, 2018

Originally I started doing this to resume work on the Http client, but realized that the changes in Ratpack that I want to use haven't actually been released yet. In any case, figured it wouldn't hurt to bump the version of Ratpack to the current release version anyway.

@codecov
Copy link

codecov bot commented May 26, 2018

Codecov Report

Merging #62 into master will decrease coverage by 1.9%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
- Coverage     84.16%   82.26%   -1.91%     
  Complexity       57       57              
============================================
  Files             7        7              
  Lines           259      265       +6     
  Branches         10       10              
============================================
  Hits            218      218              
- Misses           33       39       +6     
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
.../ratpack/zipkin/internal/ZipkinHttpClientImpl.java 66.33% <0%> (-4.19%) 14 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea9b35...48f8281. Read the comment docs.

@@ -251,6 +269,11 @@ public RequestSpec maxContentLength(int numBytes) {
return this;
}

@Override
public RequestSpec responseMaxChunkSize(final int numBytes) {
return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops this :P

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@hyleung hyleung mentioned this pull request Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants