This repository has been archived by the owner on Jan 3, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Upgrade to Ratpack v1.5.4 #62
Open
hyleung
wants to merge
5
commits into
master
Choose a base branch
from
upgrade-ratpack
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
============================================
- Coverage 84.16% 82.26% -1.91%
Complexity 57 57
============================================
Files 7 7
Lines 259 265 +6
Branches 10 10
============================================
Hits 218 218
- Misses 33 39 +6
Partials 8 8
Continue to review full report at Codecov.
|
@@ -251,6 +269,11 @@ public RequestSpec maxContentLength(int numBytes) { | |||
return this; | |||
} | |||
|
|||
@Override | |||
public RequestSpec responseMaxChunkSize(final int numBytes) { | |||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops this :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️
Closed
hyleung
force-pushed
the
upgrade-ratpack
branch
from
December 9, 2018 04:51
834bfd7
to
37ecde1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I started doing this to resume work on the Http client, but realized that the changes in Ratpack that I want to use haven't actually been released yet. In any case, figured it wouldn't hurt to bump the version of Ratpack to the current release version anyway.