Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atomics support in the standard library #1637

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add atomics support in the standard library #1637

wants to merge 4 commits into from

Conversation

lucteo
Copy link
Contributor

@lucteo lucteo commented Dec 20, 2024

No description provided.

Base automatically changed from atomics_store_load_intrinsics to main December 24, 2024 12:24
@lucteo lucteo requested a review from kyouko-taiga January 2, 2025 09:30
@lucteo
Enable "output on failure" when running tests with ctest.
14be838 
This way, we know more about what failed, and not get just "exception".
@lucteo
Copy link
Contributor Author

lucteo commented Jan 3, 2025

@kyouko-taiga : Do you have any idea why I get a "Sources/FrontEnd/TypeChecking/TypeChecker.swift:6183: Assertion failed: type already inferred" error on many of the tests on Ubuntu builds (see https://github.com/hylo-lang/hylo/actions/runs/12597537109/job/35110729555?pr=1637)?

@kyouko-taiga
Copy link
Contributor

@kyouko-taiga : Do you have any idea why I get a "Sources/FrontEnd/TypeChecking/TypeChecker.swift:6183: Assertion failed: type already inferred" error on many of the tests on Ubuntu builds (see https://github.com/hylo-lang/hylo/actions/runs/12597537109/job/35110729555?pr=1637)?

It means something causes the type checker to visit the same tree twice. If you point me at the test cases that are failing I can investigate if you want.

@lucteo
Copy link
Contributor Author

lucteo commented Jan 9, 2025

The failures can be seen at https://github.com/hylo-lang/hylo/actions/runs/12597537109/job/35110729555?pr=1637.
It shows me the following failed tests:

	  2 - DriverTests (ILLEGAL)
	  3 - ManglingTests (ILLEGAL)
	  4 - HyloTests (ILLEGAL)
	  5 - HyloTests_TestCases_Lowering_0 (ILLEGAL)
	  6 - HyloTests_TestCases_Lowering_1 (ILLEGAL)
	  7 - HyloTests_TestCases_Lowering_2 (ILLEGAL)
	  8 - HyloTests_TestCases_Lowering_3 (ILLEGAL)
	  9 - HyloTests_TestCases_Parsing_0 (ILLEGAL)
	 10 - HyloTests_TestCases_Parsing_1 (ILLEGAL)
	 11 - HyloTests_TestCases_Parsing_2 (ILLEGAL)
	 12 - HyloTests_TestCases_TypeChecking_0 (ILLEGAL)
	 13 - HyloTests_TestCases_TypeChecking_1 (ILLEGAL)
	 14 - HyloTests_TestCases_TypeChecking_2 (ILLEGAL)
	 15 - HyloTests_TestCases_TypeChecking_3 (ILLEGAL)
	 16 - HyloTests_TestCases_TypeChecking_4 (ILLEGAL)
	 17 - HyloTests_TestCases_TypeChecking_5 (ILLEGAL)
	 18 - HyloTests_TestCases_TypeChecking_6 (ILLEGAL)
	 19 - HyloTests_TestCases_TypeChecking_7 (ILLEGAL)
	 20 - HyloTests_TestCases_TypeChecking_8 (ILLEGAL)
	 21 - HyloTests_TestCases_TypeChecking_9 (ILLEGAL)
	 22 - HyloTests_TestCases_TypeChecking_10 (ILLEGAL)
	 23 - EndToEndTests (ILLEGAL)
	 24 - EndToEndTests_TestCases_0 (ILLEGAL)
	 25 - EndToEndTests_TestCases_1 (ILLEGAL)
	 26 - EndToEndTests_TestCases_2 (ILLEGAL)
	 27 - EndToEndTests_TestCases_3 (ILLEGAL)
	 28 - EndToEndTests_TestCases_4 (ILLEGAL)
	 29 - EndToEndTests_TestCases_Concurrency (ILLEGAL)
	 31 - LibraryTests_TestCases_0 (ILLEGAL)
	 32 - LibraryTests_TestCases_1 (ILLEGAL)

Please note that these tests only fail on Ubuntul, I haven't seen any failures on MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyouko-taiga kyouko-taiga Awaiting requested review from kyouko-taiga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucteo @kyouko-taiga