[Fix] - Store Kit 1 race condition #2604

arthurgeron · 2023-11-08T17:40:58Z

Similar to #2518, this fixes race condition crashes on validProducts and productsRequest in RNIapIos.swift when using Store Kit 1.

React Native IAP

What was done:

Created ThreadSafe class; Which now wraps validProducts.
Created LatestPromiseKeeper;
- Only maintains latest promise, fixes racing condition when multiple productsRequest are made in parallel. By resolving only one promise at any given time (only for productsRequest), we eliminate any possibility of causing racing conditions or bad exec exceptions while storing the resolved data.
- If more than one promise is made, older promises will be discarded and return a rejection.

IAPExample (iOS)

Fixed target iOS deployment being loaded from a undefined variable, now, it fetches the project's target iOS from the Xcode project and applies it during pod install
Updated GitHub Action to use Node.js 20
Changed GitHub Action runner from M1 arch to Intel based macOS (fixes crash during build)

hyochan

@arthurgeron Could you kindly check on the CI failing before going further?
https://github.com/dooboolab-community/react-native-iap/actions/runs/6801993699/job/18494078412

Thanks in advance!

arthurgeron · 2023-11-13T14:30:21Z

@arthurgeron Could you kindly check on the CI failing before going further? https://github.com/dooboolab-community/react-native-iap/actions/runs/6801993699/job/18494078412

Thanks in advance!

Thank you for your patience. I've fixed the SwiftLint errors!

arthurgeron · 2023-11-13T20:00:29Z

@hyochan I'm not sure why the iapExample ios build is failing.

Yann-prak · 2023-12-13T15:59:08Z

Hi,

Do you need some help to get through this PR ? What's missing ? :)

## docs fixes - improve setup of project - remove not working scripts and urls - I managed to get Android example app to work, but unfortunately not the iOS, see notes bellow: ## update `IAPExample` React to `18.2.0` - because of `TypeError: undefined is not an object (evaluating 'ReactCurrentActQueue$1.isBatchingLegacy')` - see here: facebook/react-native#34079 ## iOS exampke currently not buildable because of: - because of obsolete pods: ``` $ yarn pods rbenv: pod: command not found The `pod' command exists in these Ruby versions: 2.7.4 ``` - see here: facebook/react-native#38921 fixed but then build failed ``` The following build commands failed: CompileC /Users/babu/Library/Developer/Xcode/DerivedData/IapExample-ddzasbbwninhdjgvtldlfwsnfkwf/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/arm64/json.o /Users/babu/work/powerful-medical/dev/react-native-iap/IapExample/ios/Pods/RCT-Folly/folly/json.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'RCT-Folly' from project 'Pods') (1 failure) ``` -> this needs more time and investigation, and the question is, is it worth the time? - anyway added warning for anybody trying to build it regarding this README --------- Co-authored-by: hyochan <[email protected]>

## Why The current example project is somewhat outdated, making it challenging for users to operate with the new SDK. They are required to use an older iOS simulator and manage various legacy issues. ## How Update the RN project to the latest version, `0.72.7`. ## Test Plan <img src="https://github.com/dooboolab-community/react-native-iap/assets/27461460/8df160e6-8e71-433c-ad6d-1e3d96851a1f" width="320"/> Run example projects in `iOS` and `Android`. ## Caveat I'm trying to understand why react-native.config.js isn't effectively embedding the local react-native-iap source code into the project. As of now, I've manually installed react-native-iap in the package.json 🤔. Reference: https://github.com/react-native-community/cli/blob/main/docs/dependencies.md

fixed issue for hyochan#2607 hyochan#2461

- add renewal info (uncomment and serialize) - change debugSerialize to serialize - there is info in this property useful for production not only for development - added transactionReasonIOS enum (to distinguish between type of renewing transactions of purchase events) see also: [JWSTransactionDecodedPayload](https://developer.apple.com/documentation/appstoreserverapi/jwstransactiondecodedpayload)

- addressing the missing currency issue in Storekit 2: https://developer.apple.com/forums/thread/689978 - adding from here: https://developer.apple.com/documentation/storekit/product/4044347-priceformatstyle - as few changes as possible

- adding user canceled error code, so we can distinguish in app what error is intention and what is real error

Update documentation according to Google’s latest requirements

arthurgeron · 2024-04-05T19:51:43Z

@hyochan I've figured out the issue with IAPExample's build on GitHub Action for iOS. Apparently there's some architecture specific issue when running with macos-latest, which uses Apple Silicon (M1), I wasn't able to consistently reproduce it on my M3 (even with Act). Switching it to Intel macOS has fixed the issue.

I took the liberty of adjusting other factors that generated some issues during my testing.

Let me know if there's anything else necessary for this to get this merged.

hkeithk · 2024-04-17T18:26:45Z

Hi @hyochan, sorry to bother, was hoping you may be able to take a look at this when you have some time. Thanks!!

hkeithk · 2024-06-03T19:32:40Z

@hyochan @andresesfm just want to give this a final try, hoping we can get some eyes on this, thank you so much

arthurgeron · 2024-06-04T15:09:30Z

@hyochan @andresesfm just want to give this a final try, hoping we can get some eyes on this, thank you so much

While not ideal, you can use patch-package to test and apply this fix to your project. Just replace the files in node_modules/react-native-iap/ios and run patch-package react-native-iap, it'll generate a diff file for the changes, then you can set it up to auto-apply the fix after each install.

arthurgeron · 2024-06-04T15:16:42Z

@hyochan
Personally, I'd prefer if calls like getProducts returned the data directly in the same Promise that is generated, instead of storing it internally and returning from a separate variable. It would delegate the responsibility of storing the data to the developer, allow for agnostic data managers (e.g. React-Query, Redux, Zustand, etc) and avoid all these issues with Racing Conditions and Thread Safety, as well as being much easier to maintain.
This is a little bit off-topic and there might be deeper reasons as to why it was made this way, but I just wanted to give my 5 cents on it anyway.

hyochan · 2024-06-11T16:43:18Z

Personally, I'd prefer if calls like getProducts returned the data directly in the same Promise that is generated, instead of storing it internally and returning from a separate variable. It would delegate the responsibility of storing the data to the developer, allow for agnostic data managers (e.g. React-Query, Redux, Zustand, etc) and avoid all these issues with Racing Conditions and Thread Safety, as well as being much easier to maintain.
This is a little bit off-topic and there might be deeper reasons as to why it was made this way, but I just wanted to give my 5 cents on it anyway.

@arthurgeron I apologize for the delayed code review. If I understood your comment correctly, you want to handle getProducts using a Promise-based approach. In the past, I have implemented this library with Promises and encountered critical issues, which I have previously documented in a blog post: https://medium.com/dooboolab/react-native-iap-v3-1259e0b0c017. Promises return only one result per command, making it impossible to handle all events in the event loop. Although I have maintained some parts of the existing Promise-based implementation, the need to return results from multiple events remains critical to avoid missing any events. This approach might actually be more appropriate for the responsibility delegation you mentioned ("It would delegate the responsibility of storing the data to the developer"). If I have misunderstood your point, please feel free to correct me.

Once again, I apologize for the delay and any inconvenience caused.

hyochan

GPT says it is perfect!
#2763 (comment)

hyochan · 2024-06-11T17:09:47Z

@arthurgeron Could you kindly check this? Then I can quickly merge this and deploy to newer version!
https://github.com/dooboolab-community/react-native-iap/actions/runs/9469799195/job/26089289144?pr=2604

arthurgeron · 2024-06-11T18:01:45Z

Welcome back @hyochan!
Swift lint issues are now fixed.
Your explanation about the reason behind how data is delivered makes sense, I appreciate your detailed explanation!

arthurgeron · 2024-06-11T20:38:42Z

@hyochan CI issues fixed but Github Actions is acting up 😅

hyochan · 2024-06-12T02:35:10Z

@hyochan CI issues fixed but Github Actions is acting up 😅

NP! It is working now :)

hyochan

LGTM!

Yann-prak · 2024-06-12T08:10:28Z

Thanks guys ! You rock ! 🚀

Arthur Geron added 8 commits November 8, 2023 13:09

feat: create ThreadSafe class

d81c087

feat: make validproducts var thread safe

be187d3

feat: create LatestPromiseKeeper

4da3557

feat: avoid conflicts with racing promises

aef6e7c

fix: promise keeper import statements

40f45be

fix: allow atomically value to be modified

b1e1513

fix: move resolve if matches logic to class

2bf2f91

fix: syntax when accessing validProducts dict

5da30a3

hyochan requested changes Nov 10, 2023

View reviewed changes

hyochan added 📱 iOS Related to iOS 🛠 bugfix All kinds of bug fixes 🍗 enhancement New feature or request labels Nov 10, 2023

fix: lint errors

8286f5c

Arthur Geron added 2 commits November 13, 2023 11:33

chore: remove unecessary comments

5a5c61f

feat: add swift files to project target

7c02787

arthurgeron force-pushed the fix/storekit1-thread-safe branch 3 times, most recently from 8ae8d4d to 7c02787 Compare November 13, 2023 17:38

cervebar and others added 9 commits January 7, 2024 17:35

Update appleSk2.ts (hyochan#2608)

c4a8369

fixed issue for hyochan#2607 hyochan#2461

feat: add ios error reason user canceled (hyochan#2616)

bd28785

- adding user canceled error code, so we can distinguish in app what error is intention and what is real error

Update purchases.mdx (hyochan#2620)

b0f47a5

Update documentation according to Google’s latest requirements

docs: update reamde

61f314b

12.12.0

5f6f2bc

fix: destination device ios

7e5cfe4

arthurgeron force-pushed the fix/storekit1-thread-safe branch from 118b7a7 to 7e5cfe4 Compare April 5, 2024 19:05

arthurgeron added 2 commits April 5, 2024 16:10

feat: disable flipper in ci example ios

cfec6fe

feat: change runner for intel macos

9911894

hkeithk mentioned this pull request Apr 5, 2024

EXC_BAD_ACCESS unhandled errors #2372

Closed

arthurgeron requested a review from hyochan June 4, 2024 15:11

ci: add code-review-gpt

0e7baaf

hyochan mentioned this pull request Jun 11, 2024

[GPT Review] - Fix Store Kit 1 race condition #2763

Closed

hyochan approved these changes Jun 11, 2024

View reviewed changes

hyochan force-pushed the main branch from 567ae41 to 4fdae65 Compare June 11, 2024 17:22

hyochan force-pushed the fix/storekit1-thread-safe branch from 14699d7 to 0e7baaf Compare June 11, 2024 17:25

chore: remove unecessary switch breakouts

60cd156

arthurgeron force-pushed the fix/storekit1-thread-safe branch from cd8af05 to 60cd156 Compare June 11, 2024 20:33

arthurgeron requested a review from hyochan June 11, 2024 23:36

hyochan merged commit 0a4236c into hyochan:main Jun 12, 2024
3 checks passed

hyochan reviewed Jun 12, 2024

View reviewed changes

arthurgeron deleted the fix/storekit1-thread-safe branch June 13, 2024 16:58

arthurgeron mentioned this pull request Jun 24, 2024

If I call getProducts, getSubscription, there is an error. #2776

Closed

hsource mentioned this pull request Jul 31, 2024

Previous request was cancelled due to a new request - iOS #2800

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] - Store Kit 1 race condition #2604

[Fix] - Store Kit 1 race condition #2604

arthurgeron commented Nov 8, 2023 •

edited

Loading

hyochan left a comment

arthurgeron commented Nov 13, 2023

arthurgeron commented Nov 13, 2023

Yann-prak commented Dec 13, 2023

arthurgeron commented Apr 5, 2024

hkeithk commented Apr 17, 2024

hkeithk commented Jun 3, 2024

arthurgeron commented Jun 4, 2024 •

edited

Loading

arthurgeron commented Jun 4, 2024

hyochan commented Jun 11, 2024 •

edited

Loading

hyochan left a comment

hyochan commented Jun 11, 2024

arthurgeron commented Jun 11, 2024 •

edited

Loading

arthurgeron commented Jun 11, 2024

hyochan commented Jun 12, 2024

hyochan left a comment

Yann-prak commented Jun 12, 2024

[Fix] - Store Kit 1 race condition #2604

[Fix] - Store Kit 1 race condition #2604

Conversation

arthurgeron commented Nov 8, 2023 • edited Loading

React Native IAP

IAPExample (iOS)

hyochan left a comment

Choose a reason for hiding this comment

arthurgeron commented Nov 13, 2023

arthurgeron commented Nov 13, 2023

Yann-prak commented Dec 13, 2023

arthurgeron commented Apr 5, 2024

hkeithk commented Apr 17, 2024

hkeithk commented Jun 3, 2024

arthurgeron commented Jun 4, 2024 • edited Loading

arthurgeron commented Jun 4, 2024

hyochan commented Jun 11, 2024 • edited Loading

hyochan left a comment

Choose a reason for hiding this comment

hyochan commented Jun 11, 2024

arthurgeron commented Jun 11, 2024 • edited Loading

arthurgeron commented Jun 11, 2024

hyochan commented Jun 12, 2024

hyochan left a comment

Choose a reason for hiding this comment

Yann-prak commented Jun 12, 2024

arthurgeron commented Nov 8, 2023 •

edited

Loading

arthurgeron commented Jun 4, 2024 •

edited

Loading

hyochan commented Jun 11, 2024 •

edited

Loading

arthurgeron commented Jun 11, 2024 •

edited

Loading