Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make the code parameter of safeReject non-nullable #2875

Merged
merged 1 commit into from
Nov 4, 2024
Merged

refactor: make the code parameter of safeReject non-nullable #2875

merged 1 commit into from
Nov 4, 2024

Commits on Nov 1, 2024

  1. refactor: make the code parameter of safeReject non-nullable 

    The reject method of Promise class became non-nullable in React Native 0.76 after rewriting it from Java to Kotlin. We fixed it being called with a nullable value in hyochan#2872 by providing and empty string as a fallback if it happens to be null. But after more investigation it seems like it's not called with a value that could be null anywhere in the code, so a better solution would be to just update the type of the `code` parameter to be non-nullable.
    @mlazari
    mlazari committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    076b729 View commit details
    Browse the repository at this point in the history