Support relative transforms on rooms

[serenayl]

Background

We are transitioning space profiles in pringle to be relative to a transform which meaningfully stores its origin and orientation.

Description

• Adds more transform awareness to space layout functions.

Testing

• Tested old Explore workflows with multiple levels to make sure things looked about the same, see an example of that with functions all in dev mode here: https://hypar.io/workflows/9965ac0c-0f81-4e91-90a0-a13b52c5a5b5
• Tested a pringle workflow with multiple orientations and levels using the space-relative-profile branch to ensure that furniture appears to work as expected. Example workflow here: http://localhost:8080/projects/79e06c4f-ede4-478b-b512-64e983186f77

---

This change is 

[andrewheumann]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained, 1 unresolved discussion (waiting on @serenayl)

---

LayoutFunctions/LayoutFunctionCommon/WallGeneration.cs line 94 at r1 (raw file):

                    wallCandidateLines.AddRange(notAdjacentToFloorBoundary.Select(s =>
                    {
                        if (!orientationGuideEdges.Select(x => x.Line.Line.TransformedLine(room.Transform)).Contains(s.Line))

I think this will always return false, since Contains is a by-reference comparison. I would almost not worry about wall generation, since we don't rely on it for pringle, and in non-pringle workflows, the spaces will always have Z-only transforms. (IOW — maybe we should just leave wall generation unchanged, knowing that it will be broken for pringle workflows)

[serenayl]

Reviewable status: 1 change requests, 0 of 1 approvals obtained, 1 unresolved discussion (waiting on @andrewheumann)

---

LayoutFunctions/LayoutFunctionCommon/WallGeneration.cs line 94 at r1 (raw file):

Previously, andrewheumann (Andrew Heumann) wrote…

I think this will always return false, since Contains is a by-reference comparison. I would almost not worry about wall generation, since we don't rely on it for pringle, and in non-pringle workflows, the spaces will always have Z-only transforms. (IOW — maybe we should just leave wall generation unchanged, knowing that it will be broken for pringle workflows)

Ah I misunderstood and thought this was a geometric check. I rolled this back but am keeping the logic related to the orientation edge finding, since that definitely did break things. Published all the layout functions to test mode again!

[andrewheumann]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained, all discussions resolved