Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doors: add 2D visualization by using TryToGraphicsBuffers override #52

Conversation

DmytroMuravskyi
Copy link
Contributor

@DmytroMuravskyi DmytroMuravskyi commented Jul 21, 2023

This change is Reviewable

Copy link
Contributor

@katehryhorenko katehryhorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 change requests, 0 of 1 approvals obtained, 2 unresolved discussions (waiting on @DmytroMuravskyi)


LayoutFunctions/Doors/dependencies/Door.cs line 57 at r1 (raw file):

        }

        private List<Vector3> DoorSchema(bool leftSide, bool inside, double angle)

The name "CreateDoorSchema" or "CreateDoorSchemaVertices" is better. The name of the function should describe the action inside.


LayoutFunctions/Doors/dependencies/Door.cs line 77 at r1 (raw file):

            if (!angle.ApproximatelyEquals(90))
            {
                Transform t = new Transform();

Please move initialization of the 't' variable closer to its usage

Copy link
Contributor Author

@DmytroMuravskyi DmytroMuravskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 change requests, 0 of 1 approvals obtained, 2 unresolved discussions (waiting on @katehryhorenko)


LayoutFunctions/Doors/dependencies/Door.cs line 57 at r1 (raw file):

Previously, katehryhorenko (Kateryna Hryhorenko) wrote…

The name "CreateDoorSchema" or "CreateDoorSchemaVertices" is better. The name of the function should describe the action inside.

Done.


LayoutFunctions/Doors/dependencies/Door.cs line 77 at r1 (raw file):

Previously, katehryhorenko (Kateryna Hryhorenko) wrote…

Please move initialization of the 't' variable closer to its usage

Done.

Copy link
Contributor

@katehryhorenko katehryhorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 1 approvals obtained, 2 unresolved discussions

@katehryhorenko katehryhorenko merged commit 7924b98 into hypar-io:master Jul 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants