Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahall avoid columns #61

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Datahall avoid columns #61

merged 5 commits into from
Aug 30, 2023

Conversation

jamesbradleym
Copy link
Contributor

@jamesbradleym jamesbradleym commented Aug 29, 2023

This PR updates the Data Hall Layout function by adding some column avoidance logic. At this stage a rack will simply not be placed where it would intersect with a column. This adds 2 new functions GetColumnsInRoom and CheckIntersectsWithColumn.


This change is Reviewable

Copy link
Contributor

@anthonie-kramer anthonie-kramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: 1 of 1 approvals obtained, 1 unresolved discussion (waiting on @jamesbradleym)


LayoutFunctions/DataHall/hypar.json line 16 at r1 (raw file):

    {
      "autohide": false,
      "name": "Columns",

In the future, we would probably want to also add the "Structure" function, since it also produces columns

@jamesbradleym jamesbradleym merged commit 1ec9255 into master Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants