Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix room orientation #62

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Fix room orientation #62

merged 4 commits into from
Sep 14, 2023

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Sep 14, 2023

Rooms were often getting oriented with their "glazed" wall not along circulation, even if circulation was present.
image

  • Adds a max dist to the default call to FindWallCandidateOptions, and also allows FindEdgeAdjacentToSegments to recover if nothing under the max dist is found. This way we always prefer segments under the max dist, but gracefully handle the case that there are none.
  • Fixes some cases where we were doing distance comparison in 3d instead of 2d
  • Updates the default meeting room configurations to have 90 degree rotated versions, since the interior orientation is mostly door-agnostic for meeting rooms.

This change is Reviewable

@andrewheumann andrewheumann merged commit 0cc8dd4 into master Sep 14, 2023
1 check failed
@andrewheumann andrewheumann deleted the fix-room-orientation branch September 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant