Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wall overrides #66

Merged
merged 12 commits into from
Dec 2, 2023
Merged

Wall overrides #66

merged 12 commits into from
Dec 2, 2023

Conversation

ikeough
Copy link
Contributor

@ikeough ikeough commented Oct 30, 2023

This is a continuation of the work started by @nadiia-volyk in #46. It updates that branch's work to master and updates the code to use RoomEdge where applicable, and to convey Thickness throughout all parts of the code which create wall candidates.

The following additional updates are still required:

  • Update code to not use an add override for lines. This was originally added for wall splitting, but is de-prioritized.
  • Update de-duplication code to use thickness. Currently if this code is enabled, we get dropped walls.

This change is Reviewable

@anthonie-kramer anthonie-kramer merged commit 52f2dbc into master Dec 2, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants