Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for wall types #67

Merged
merged 3 commits into from
Nov 1, 2023
Merged

add support for wall types #67

merged 3 commits into from
Nov 1, 2023

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Oct 30, 2023 •
edited
Loading

  • Deprecate all Create Walls inputs to layout functions
  • Update LayoutFunctionCommon to defer to the space's Default Wall Type rather than its built-in type preferences.

This change is Reviewable

@andrewheumann andrewheumann mentioned this pull request Oct 30, 2023
Merged
anthonie-kramer
anthonie-kramer approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@anthonie-kramer anthonie-kramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 35 of 35 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained, all discussions resolved

@andrewheumann andrewheumann merged commit 7fdc1be into master Nov 1, 2023
1 check failed
@andrewheumann andrewheumann deleted the wall-types branch November 1, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonie-kramer anthonie-kramer anthonie-kramer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheumann @anthonie-kramer