Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug_span in poll_complete loop #764

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add debug_span in poll_complete loop #764

wants to merge 4 commits into from

Conversation

YHM404
Copy link

@YHM404 YHM404 commented Apr 11, 2024

Resolve #763

@seanmonstar
Copy link
Member

It's not clear how this is an improvement, the span will still have a parent that lives a long time.

However, I don't think that the parent span is a problem at all, but rather the subscriber implementation that simply grows forever. That's not h2's fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak caused by the long-lifespan trace_debug_span within the reused connection
3 participants
@YHM404 @seanmonstar @hawkw