Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double quote from header name validation as per spec #716

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Remove double quote from header name validation as per spec #716

merged 1 commit into from
Sep 17, 2024

Conversation

chen-hongzhi
Copy link
Contributor

Double quotes don't seem to be in the allowed tokens for the name field.

      separators     = "(" | ")" | "<" | ">" | "@"
                     | "," | ";" | ":" | "\" | <">
                     | "/" | "[" | "]" | "?" | "="
                     | "{" | "}" | SP | HT
      token          = 1*tchar
      tchar          = "!" / "#" / "$" / "%" / "&" / "'" / "*"
                     / "+" / "-" / "." / "^" / "_" / "`" / "|" / "~"
                     / DIGIT / ALPHA
                     ; any VCHAR, except delimiters

seanmonstar
seanmonstar approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@seanmonstar seanmonstar enabled auto-merge (squash) September 17, 2024 19:20
@seanmonstar seanmonstar merged commit 308104b into hyperium:master Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chen-hongzhi @seanmonstar