feat(error): preserve InvalidUri
details
#3044
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch changes the representation of the
Parse::Uri
error kind to preserve information provided by thehttp
crate'suri::InvalidUri
anduri::InvalidUriParts
errors. A newInvalidUri
enum is added that holds one of those two error types, or a custom message (sincehyper
currently returnsParse::Uri
errors that didn't come from an innerhttp
error in some cases). The new enum has a customDisplay
andDebug
implementation to reduce repetition of the string "invalid URI" in its formatted output.This is not stored as the error's
cause
currently in order to avoid exposing thehttp
crate's error types in the public API. However, whenhttp
1.0 is released, we can simplify this code significantly by storing the error as a cause and exposing it in the source chain.Closes #3043