feat(ext): add ext::on_informational()
callback extension
#3818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new function allows attaching a callback to a request, such that when it is sent through a hyper client connection, and any 1xx informational responses are received, they are passed to the callback.
Closes #2565
This takes the unstable client informational feature (introduced in #2594, tracking issue in #2565), and promotes it to a stable API. The way it works is largely the same: a user can embed a callback in an extension in a request, and if present, it is called with each 1xx response parsed for that request.
As long as it was working in an unstable manor for curl, we didn't really discuss further if it is particularly rusty. I welcome feedback to that effect.
Alternatives
ResponseFuture
instead. Some of the downsides I feel with that design are:ResponseFuture
into animpl Future
ordyn Future
(orasync fn
) slightly higher up loses the ability to call those methods, or expose that functionality to users. For instance, composition in atower
stack.