Implement mailbox process #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkporter
reviewed
Dec 8, 2022
yorhodes
force-pushed
the
yorhodes/multisig-ism
branch
from
fb68bc9 to
4913a82
Compare
yorhodes
force-pushed
the
yorhodes/mailbox-process
branch
from
fe1d911 to
dc7cf39
Compare
yorhodes
force-pushed
the
yorhodes/multisig-ism
branch
from
6b4dbcf to
c6aac86
Compare
yorhodes
force-pushed
the
yorhodes/mailbox-process
branch
from
2eab1e2 to
6b7ce79
Compare
tkporter
reviewed
Dec 14, 2022
| @@ -22,9 +23,15 @@ const VERSION: u8 = 0; | |||
| // "fuel" in bytes | |||
| const LOCAL_DOMAIN: u32 = 0x6675656cu32; | |||
|
|
|||
| const ZERO_ID: ContractId = ContractId { | |||
| value: 0x0000000000000000000000000000000000000000000000000000000000000000, | |||
There was a problem hiding this comment.
can you use ZERO_B256 here?
There was a problem hiding this comment.
I think you meant to change this to ZERO_B256 because of the import?
yorhodes
force-pushed
the
yorhodes/mailbox-process
branch
from
c3c3467 to
efdb340
Compare
* Add interfaces pkg and make multisig ism compat * Make ISM verify write
yorhodes
commented
Dec 15, 2022
tkporter
reviewed
Dec 19, 2022
yorhodes
force-pushed
the
yorhodes/mailbox-process
branch
from
872bdde to
63f098f
Compare
tkporter
approved these changes
Dec 21, 2022
| @@ -22,9 +23,15 @@ const VERSION: u8 = 0; | |||
| // "fuel" in bytes | |||
| const LOCAL_DOMAIN: u32 = 0x6675656cu32; | |||
|
|
|||
| const ZERO_ID: ContractId = ContractId { | |||
| value: 0x0000000000000000000000000000000000000000000000000000000000000000, | |||
There was a problem hiding this comment.
I think you meant to change this to ZERO_B256 because of the import?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Touches #28