Mailbox indexer #39

tkporter · 2023-01-06T12:07:07Z

Moves to the recommended repo structure for an indexer project: https://fuellabs.github.io/fuel-indexer/v0.1.12/getting-started/fuel-indexer-project.html#with-a-fuel-project
Adds log_with_id to bytes_extended, which is used for logging dispatched messages. The rationale is that logs generated by forc compiler make use of the rB register (see https://fuellabs.github.io/fuel-specs/master/vm/instruction_set.html#logd-log-data-event) to have a marker value so that logs can be identified / differentiated. The compiler will look at all logs and generate marker values starting with 0 and counting upward, and it generates the corresponding log/logd instructions with these marker values. You can see these are also present in the ABI if you look at the loggedTypes section. Because we're calling the logd instruction directly in an asm block, we don't get the luxury of the compiler auto-generating a marker value to easily identify this log, so we have to do it manually. This is imo the easiest way to allow us to easily identify dispatched message logs. Tbh I'd be open to other options here, either in this PR or in the future when we revisit Fuel with greater effort closer to their mainnet date
Adds indexer/mailbox, which so far indexes dispatched messages. There are a number of necessary quirks that I've done my best to annotate with comments & relevant issues. I recommend reading the README.md in there first and referring to the Fuel Indexer Book / docs as needed.
Adds the deploy package, adapted from Super basic deploy tooling #15. It now allows messages to be sent
Drive-by update to forc to 0.35.5, some cargo fmt, and cargo clippy changes

ControlCplusControlV · 2023-01-09T05:36:37Z

If you add this to your .gitattributes it will add syntax highlighting on Github btw

…revor/indexer

yorhodes

couldn't get deployment working so have much still to test but great work and docs!

yorhodes · 2023-03-20T20:47:41Z

deploy/src/deploy.ts

+  const expectedMailboxContractId = ContractUtils.getContractId(
+    bytecode,
+    CONTRACT_SALT,
+    ContractUtils.getContractStorageRoot([]),


why is ID derived from storage root?

Check out https://specs.fuel.network/master/protocol/id/contract.html#contract-id, it's just part of the way they implemented computing IDs when a contract is deployed

yorhodes · 2023-03-20T20:48:52Z

deploy/src/deploy.ts

+  if (maybeDeployedContract) {
+    console.log('Contract already deployed');
+    return new Contract(
+      expectedMailboxContractId,
+      HyperlaneMailboxAbi__factory.abi,
+      wallet,
+    );
+  }
+
+  console.log('Deploying contract...');
+  return factory.deployContract({
+    salt: CONTRACT_SALT,


does factory.deployContract fail if already deployed?

yeah it does, you get something like this:

Error: ClientError: Transaction(0x74deef4b669dfca1d2a5e1679639c29ea53e572268fa123e7359286f85c9711d) execution error: Panic(ContractIdAlreadyDeployed)

indexer/mailbox/README.md

deploy/README.md

yorhodes · 2023-03-20T21:39:04Z

deploy/README.md

+In another terminal, build and deploy the Mailbox. This is idempotent if just deploying the mailbox.
+
+```
+yarn deploy


did you have yarn local-node running in a different terminal?

hmmmm interesting
I assume you did a fresh yarn in the deploy package?

caused by node v19

yorhodes · 2023-03-20T21:59:39Z

indexer/mailbox/schema/mailbox.schema.graphql

+type DispatchedMessage {
+    # The nonce as a u64
+    # See https://fuellabs.github.io/fuel-indexer/master/components/database/ids.html
+    id: ID!


easily conflated with contract_id

yorhodes · 2023-03-20T22:05:29Z

indexer/mailbox/src/lib.rs

+            // See https://fuellabs.github.io/fuel-indexer/v0.1.12/components/database/ids.html
+            id: message.nonce as u64,


ah nvm about the id comment then

yorhodes · 2023-03-20T22:06:32Z

indexer/mailbox/src/lib.rs

+            contract_id: log_metadata.contract_id,
+            block_number: log_metadata.block_number,
+            block_hash: log_metadata.block_hash,
+            transaction_hash: log_metadata.transaction_hash,
+            transaction_index: log_metadata.transaction_index,
+            receipt_index: log_metadata.receipt_index,
+        }


is there no spread operator?

unfortunately no
The closest is you can do:

MyStruct { foo, ..my_existing_struct }

but my_existing_struct has to be an instance of the MyStruct struct

indexer/mailbox/src/message.rs

yorhodes · 2023-03-20T22:11:01Z

indexer/mailbox/src/message.rs

+impl HyperlaneMessage {
+    /// Convert the message to a message id
+    pub fn id(&self) -> H256 {
+        H256::from_slice(Keccak256::new().chain(self.to_vec()).finalize().as_slice())


bit hard to read

Also copied directly from the monorepo so I'm inclined to leave as is

But what I can do instead is do what I mention here https://github.com/hyperlane-xyz/fuel-contracts/pull/39/files/ec0ceaccbbbd620dbb78207bb1d2735c98a0f287#diff-c1df921b29777e810d4612bf6e315c71cf5f404d83cf0413cdeea3b4d2134aceR10 and move these into their own crate in the monorepo so that we don't need to copy and paste these

actually this may be a decent undertaking so I'd like to not block this PR on that. I created hyperlane-xyz/hyperlane-monorepo#1977 to do this later

…cts into trevor/indexer

tkporter · 2023-03-21T16:52:41Z

indexer/mailbox/schema/mailbox.schema.graphql

+
+    message_id: Bytes32!
+
+    # TODO: rip the following out into a LogMetadata type.


Tracking this with #50

tkporter added 13 commits January 3, 2023 09:54

Reorganize repo

f377dc9

Progress

57aba82

Working decently well, need to figure out Blob

17ce001

forc fmt

fed9383

Having issues cargo testing ...

99f5539

Fix abi

523c7d0

fix the tests

e912996

not really sure why it's not working anymore

a04f778

Trying to clean up

a5b5ba4

README updates

0c13e8f

Add a bunch of instructions, clean up

cca72a8

clean up

df902de

Clippy and clean up

f180e6e

tkporter requested a review from yorhodes January 6, 2023 12:07

try new toml

c40f35b

tkporter mentioned this pull request Mar 14, 2023

Revive & merge indexer work #45

Closed

tkporter added 3 commits March 20, 2023 12:14

Merge branch 'main' of github.com:hyperlane-xyz/fuel-contracts into t…

5a490c6

…revor/indexer

It's not perfect but it builds

ae7c18e

Got it working again

ec0ceac

tkporter mentioned this pull request Mar 20, 2023

Investigate a better way of logging dispatched messages #49

Closed

Add ts-node dev dependency

97cb6e7

yorhodes reviewed Mar 20, 2023

View reviewed changes

tkporter added 2 commits March 21, 2023 10:22

PR comments

d239ca0

Fix build

0f2287b

This was referenced Mar 21, 2023

Pull core rust types into their own crate with WASM-compatible dependencies hyperlane-xyz/hyperlane-monorepo#1977

Closed

Super basic deploy tooling #15

Closed

tkporter added 2 commits March 21, 2023 16:47

Use Blob type

9608bc1

Merge branch 'trevor/indexer' of github.com:hyperlane-xyz/fuel-contra…

5dc2ba2

…cts into trevor/indexer

tkporter commented Mar 21, 2023

View reviewed changes

Add warning to README about node version

6ef5ea3

yorhodes approved these changes Mar 23, 2023

View reviewed changes

yorhodes merged commit 895fbc2 into main Mar 23, 2023

yorhodes mentioned this pull request Mar 23, 2023

Basic contract deploy tooling #9

Closed

This was referenced Mar 26, 2023

Create indexer to index dispatched messages #37

Closed

Reorganize the repo #28

Closed

Local Mailbox deploy setup to use for agent development #13

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mailbox indexer #39

Mailbox indexer #39

tkporter commented Jan 6, 2023 •

edited

Loading

ControlCplusControlV commented Jan 9, 2023

yorhodes left a comment

yorhodes Mar 20, 2023

tkporter Mar 21, 2023

yorhodes Mar 20, 2023

tkporter Mar 21, 2023

yorhodes Mar 20, 2023

tkporter Mar 21, 2023

yorhodes Mar 21, 2023

tkporter Mar 21, 2023

yorhodes Mar 23, 2023

yorhodes Mar 20, 2023

yorhodes Mar 20, 2023

yorhodes Mar 20, 2023

tkporter Mar 21, 2023

yorhodes Mar 20, 2023

tkporter Mar 21, 2023

tkporter Mar 21, 2023

tkporter Mar 21, 2023

		// See https://fuellabs.github.io/fuel-indexer/v0.1.12/components/database/ids.html
		id: message.nonce as u64,


		message_id: Bytes32!

		# TODO: rip the following out into a LogMetadata type.

Mailbox indexer #39

Mailbox indexer #39

Conversation

tkporter commented Jan 6, 2023 • edited Loading

ControlCplusControlV commented Jan 9, 2023

yorhodes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tkporter commented Jan 6, 2023 •

edited

Loading