Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add information to msg transaction cards #104

Merged
merged 4 commits into from
Aug 16, 2024
Merged

feat: Add information to msg transaction cards #104

merged 4 commits into from
Aug 16, 2024

Conversation

jmrossy
Copy link
Collaborator

@jmrossy jmrossy commented Aug 16, 2024

  • Display duration in dest tx card per request from @Skunkchain
  • Display mailbox address in both tx cards
  • Hide API docs page link which was disabled in fix: remove api code #77
  • Fix missing type annotation

@jmrossy
Display duration in dest tx card
a5304a3 
Hide API docs page link
Fix missing type annotation
@jmrossy jmrossy requested review from paulbalaji and avious00 August 16, 2024 15:49
@jmrossy jmrossy requested a review from yorhodes as a code owner August 16, 2024 15:49
@vercel Vercel
Copy link

vercel bot commented Aug 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperlane-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 4:10pm

paulbalaji
paulbalaji reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@paulbalaji paulbalaji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, curious why the mailbox is unknown for this tx https://hyperlane-explorer-k2eikc3ff-abacus-works.vercel.app/message/0xc271e92077b44728043c61308f1e607cb6df4a21599ab52c25dccc1ac2095822

nvm it updated

@jmrossy
Copy link
Collaborator Author

jmrossy commented Aug 16, 2024

@paulbalaji added protection for the case where the mailbox is not yet known

@jmrossy jmrossy enabled auto-merge (squash) August 16, 2024 16:09
@jmrossy jmrossy merged commit 2309073 into main Aug 16, 2024
6 checks passed
@jmrossy jmrossy deleted the rossy/display-duration branch August 16, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalaji paulbalaji paulbalaji approved these changes

@avious00 avious00 Awaiting requested review from avious00

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmrossy @paulbalaji