feat: sync url with filters #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jmrossy
reviewed
Dec 12, 2024
| <SearchError | ||
| show={show} | ||
| imgSrc={ErrorIcon} | ||
| text="Sorry, the origin or destination chain is invalid. Please try choosing another chain or cleaning your filters." |
There was a problem hiding this comment.
Suggested change
| text="Sorry, the origin or destination chain is invalid. Please try choosing another chain or cleaning your filters." | |
| text="Sorry, either the origin or the destination chain is invalid. Please choose a different chain or clear your search filters." |
Comment on lines
146
to
149
| isValidInput && | ||
| isValidOrigin && | ||
| isValidDestination && | ||
| isAnyMessageFound && |
There was a problem hiding this comment.
Long list, should we make a var above to combine these?
There was a problem hiding this comment.
created a showMessageTable variable to combine these
| @@ -21,6 +22,11 @@ export function isValidSearchQuery(input: string) { | |||
| return !!searchValueToPostgresBytea(input); | |||
| } | |||
|
|
|||
| export function isValidDomainId(domainId: string | null, multiProvider: MultiProvider) { | |||
| if (!domainId) return false; | |||
| return !!multiProvider.tryGetDomainId(domainId); | |||
There was a problem hiding this comment.
Suggested change
| return !!multiProvider.tryGetDomainId(domainId); | |
| return multiProvider.hasChain(domainId); |
There was a problem hiding this comment.
Didn't know there was a function for this, thanks!
src/utils/queryParams.ts
Outdated
Comment on lines
42
to
43
| if (value) { | ||
| if (newQuery.get(key) !== value) { |
There was a problem hiding this comment.
Awkward structure, combine these
src/utils/queryParams.ts
Outdated
Comment on lines
47
to
48
| } else { | ||
| if (newQuery.has(key)) { |
jmrossy
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #145
originanddestinationand their value will be adomainId. Inputting an invaliddomainIdwill prompt theSearchChainErrorcomponent to showstartTimeandendTimeand their value is a number. The initial load of the values are validated by the functiontryToDecimalNumber()