chore: minor refactoring

hyperlane-xyz · Oct 9, 2024 · 0891c62 · 0891c62
1 parent 8b5afe3
commit 0891c62
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/solidity/solidity/lib/foundry-zksync b/solidity/solidity/lib/foundry-zksync
diff --git a/typescript/cli/src/deploy/utils.ts b/typescript/cli/src/deploy/utils.ts
@@ -48,8 +48,7 @@ export async function runPreflightChecksForChains({
     const metadata = multiProvider.tryGetChainMetadata(chain);
     if (!metadata) throw new Error(`No chain config found for ${chain}`);
     if (
-      metadata.protocol !== ProtocolType.Ethereum &&
-      metadata.protocol !== ProtocolType.ZKSync
+      ![ProtocolType.ZKSync, ProtocolType.Ethereum].includes(metadata.protocol)
     )
       throw new Error('Only Ethereum/ZKSync chains are supported for now');
   }

diff --git a/typescript/cli/src/hook/read.ts b/typescript/cli/src/hook/read.ts
@@ -21,8 +21,9 @@ export async function readHookConfig({
 }): Promise<void> {
   // TODO: refactor to supported chains function
   if (
-    context.multiProvider.getProtocol(chain) === ProtocolType.Ethereum ||
-    context.multiProvider.getProtocol(chain) === ProtocolType.ZKSync
+    [ProtocolType.ZKSync, ProtocolType.Ethereum].includes(
+      context.multiProvider.getProtocol(chain),
+    )
   ) {
     const hookReader = new EvmHookReader(context.multiProvider, chain);
     const config = await hookReader.deriveHookConfig(address);

diff --git a/typescript/sdk/src/contracts/contracts.ts b/typescript/sdk/src/contracts/contracts.ts
@@ -244,10 +244,9 @@ export function appFromAddressesMapHelper<F extends HyperlaneFactories>(
     addressesMap,
     (chain, addresses) => {
       const metadata = multiProvider.getChainMetadata(chain);
-      if (metadata.protocol === ProtocolType.ZKSync) {
-        return addresses;
-      }
-      if (metadata.protocol === ProtocolType.Ethereum) {
+      if (
+        [ProtocolType.ZKSync, ProtocolType.Ethereum].includes(metadata.protocol)
+      ) {
         return addresses;
       }
       return objMap(

diff --git a/typescript/utils/src/addresses.ts b/typescript/utils/src/addresses.ts
@@ -206,7 +206,7 @@ export function isValidTransactionHashCosmos(input: string) {
 }
 
 export function isValidTransactionHash(input: string, protocol: ProtocolType) {
-  if (protocol === ProtocolType.Ethereum || protocol === ProtocolType.ZKSync) {
+  if ([ProtocolType.Ethereum, ProtocolType.ZKSync].includes(protocol)) {
     return isValidTransactionHashEvm(input);
   } else if (protocol === ProtocolType.Sealevel) {
     return isValidTransactionHashSealevel(input);