Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hyperlane AVS contracts #3651

Merged
merged 38 commits into from
May 9, 2024

Merge branch 'main' into kunal/avs-contracts

13f6da8
Select commit
Loading
Failed to load commit list.
Merged

feat: Hyperlane AVS contracts #3651

Merge branch 'main' into kunal/avs-contracts
13f6da8
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither failed May 9, 2024 in 5s

27 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

  • 1 high
  • 11 medium
  • 13 low

Other Alerts:

  • 2 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 211 in solidity/contracts/avs/ECDSAServiceManagerBase.sol

See this annotation in the file changed.

Check warning on line 340 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Uninitialized local variables Medium

ECDSAStakeRegistry._updateOperatorWeight(address).newWeight is a local variable never initialized

Check warning on line 252 in solidity/contracts/avs/ECDSAServiceManagerBase.sol

See this annotation in the file changed.

Code scanning / Slither

Uninitialized local variables Medium

ECDSAServiceManagerBase._getOperatorRestakedStrategies(address).activeCount is a local variable never initialized

Check warning on line 69 in solidity/script/avs/DeployAVS.s.sol

See this annotation in the file changed.

Code scanning / Slither

Uninitialized local variables Medium

DeployAVS._loadEigenlayerAddresses(string).multiplier is a local variable never initialized

Check warning on line 339 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Uninitialized local variables Medium

ECDSAStakeRegistry._updateOperatorWeight(address).delta is a local variable never initialized

Check warning on line 358 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

ECDSAStakeRegistry._updateOperatorWeight(address) ignores return value by _operatorWeightHistory[_operator].push(newWeight)

Check warning on line 230 in solidity/contracts/avs/HyperlaneServiceManager.sol

See this annotation in the file changed.

Check warning on line 285 in solidity/contracts/avs/HyperlaneServiceManager.sol

See this annotation in the file changed.

Check warning on line 358 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

ECDSAStakeRegistry._updateOperatorWeight(address) ignores return value by _operatorWeightHistory[_operator].push(0)

Check warning on line 211 in solidity/contracts/avs/ECDSAServiceManagerBase.sol

See this annotation in the file changed.

Check warning on line 372 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

ECDSAStakeRegistry._updateTotalWeight(int256) ignores return value by _totalWeightHistory.push(newTotalWeight)

Check warning on line 273 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

ECDSAStakeRegistry._updateStakeThreshold(uint256) ignores return value by _thresholdWeightHistory.push(_thresholdWeight)

Check notice on line 40 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Local variable shadowing Low

ECDSAStakeRegistry.initialize(address,uint256,Quorum)._serviceManager shadows:
- ECDSAStakeRegistryStorage._serviceManager (state variable)

Check notice on line 382 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Local variable shadowing Low

ECDSAStakeRegistry._isValidQuorum(Quorum)._quorum shadows:
- ECDSAStakeRegistryStorage._quorum (state variable)

Check notice on line 78 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Local variable shadowing Low

ECDSAStakeRegistry.updateQuorumConfig(Quorum,address[])._quorum shadows:
- ECDSAStakeRegistryStorage._quorum (state variable)

Check notice on line 42 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Local variable shadowing Low

ECDSAStakeRegistry.initialize(address,uint256,Quorum)._quorum shadows:
- ECDSAStakeRegistryStorage._quorum (state variable)

Check notice on line 229 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Local variable shadowing Low

ECDSAStakeRegistry.__ECDSAStakeRegistry_init(address,uint256,Quorum)._quorum shadows:
- ECDSAStakeRegistryStorage._quorum (state variable)

Check notice on line 230 in solidity/contracts/avs/HyperlaneServiceManager.sol

See this annotation in the file changed.

Check notice on line 89 in solidity/script/avs/DeployAVS.s.sol

See this annotation in the file changed.

Check notice on line 188 in solidity/contracts/avs/ECDSAServiceManagerBase.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in ECDSAServiceManagerBase._deregisterOperatorFromAVS(address):
External calls:
- IAVSDirectory(avsDirectory).deregisterOperatorFromAVS(operator)
Event emitted after the call(s):
- OperatorDeregisteredFromAVS(operator)

Check notice on line 296 in solidity/contracts/avs/HyperlaneServiceManager.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in HyperlaneServiceManager._deregisterOperatorFromAVS(address):
External calls:
- IAVSDirectory(avsDirectory).deregisterOperatorFromAVS(operator)
Event emitted after the call(s):
- OperatorDeregisteredFromAVS(operator)

Check notice on line 332 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Check notice on line 178 in solidity/contracts/avs/ECDSAServiceManagerBase.sol

See this annotation in the file changed.

Check notice on line 312 in solidity/contracts/avs/ECDSAStakeRegistry.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in ECDSAStakeRegistry._deregisterOperator(address):
External calls:
- IServiceManager(_serviceManager).deregisterOperatorFromAVS(_operator)
Event emitted after the call(s):
- OperatorDeregistered(_operator,address(_serviceManager))

Check warning on line 31 in solidity/contracts/avs/ECDSAStakeRegistryStorage.sol

See this annotation in the file changed.

Code scanning / Slither

State variables that could be declared constant Warning

ECDSAStakeRegistryStorage._stakeExpiry should be constant