Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sinon import in exported lib files #3685

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented May 1, 2024

Description

testUtils gets used by TestCoreDeployer which gets exported from the SDK, so we can't import sinon there. We should reorganize these test utils

@jmrossy jmrossy requested a review from yorhodes as a code owner May 1, 2024 05:38
Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: e4bc803

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmrossy jmrossy enabled auto-merge (squash) May 1, 2024 05:38
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.28%. Comparing base (3528b28) to head (e4bc803).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3685   +/-   ##
=======================================
  Coverage   74.28%   74.28%           
=======================================
  Files         108      108           
  Lines        1217     1217           
  Branches      132      132           
=======================================
  Hits          904      904           
  Misses        297      297           
  Partials       16       16           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 69.94% <ø> (ø)
isms 73.17% <ø> (ø)
token 63.77% <ø> (ø)
middlewares 77.48% <ø> (ø)

@jmrossy jmrossy merged commit cf727db into main May 1, 2024
34 of 35 checks passed
@jmrossy jmrossy deleted the rossy/sdk-sinon-fix branch May 1, 2024 18:02
ltyu pushed a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants