Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add defaultDescription to yargs --key option #3697

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

nbayindirli
Copy link
Contributor

@nbayindirli nbayindirli commented May 2, 2024

Description

  • Adds defaultDescription to yargs --key option to avoid printing sensitive data

Drive-by changes

  • None

Related issues

  • None

Backward compatibility

  • Yes

Testing

  • Manual

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 0ec994d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hyperlane-xyz/cli Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nbayindirli nbayindirli changed the title Redact printed PK Adds defaultDescription to yargs --key option. May 2, 2024
@nbayindirli nbayindirli changed the title Adds defaultDescription to yargs --key option. add defaultDescription to yargs --key option May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.28%. Comparing base (0288835) to head (0ec994d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3697   +/-   ##
=======================================
  Coverage   74.28%   74.28%           
=======================================
  Files         108      108           
  Lines        1217     1217           
  Branches      132      132           
=======================================
  Hits          904      904           
  Misses        297      297           
  Partials       16       16           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 69.94% <ø> (ø)
isms 73.17% <ø> (ø)
token 63.77% <ø> (ø)
middlewares 77.48% <ø> (ø)

@nbayindirli nbayindirli merged commit 8246f14 into main May 2, 2024
34 of 35 checks passed
@nbayindirli nbayindirli deleted the noah/pk-print branch May 2, 2024 20:03
ltyu pushed a commit that referenced this pull request May 3, 2024
### Description

* Adds defaultDescription to yargs --key option to avoid printing
sensitive data

### Drive-by changes

* None

### Related issues

* None

### Backward compatibility

* Yes

### Testing

* Manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants