Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): ezETH deploy fixes #4009

Merged
merged 8 commits into from
Jul 1, 2024
Merged

fix(cli): ezETH deploy fixes #4009

merged 8 commits into from
Jul 1, 2024

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented Jun 19, 2024

Description

some minor fixes to make the ezEth deploy work. Does not include the modifications to contract verification retries that I made.

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: 832697d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/core Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nbayindirli nbayindirli changed the title ezETH deploy fixes fix(cli): ezETH deploy fixes Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d35b546) to head (832697d).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4009   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         14      14           
=====================================
  Misses        14      14           
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)

paulbalaji added a commit that referenced this pull request Jun 20, 2024
@paulbalaji
Copy link
Contributor

may have to pull in changes from cli-2.0, as the cli-e2e ci job has been renamed

Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should fix the balance sufficient check

typescript/cli/src/utils/balances.ts Outdated Show resolved Hide resolved
typescript/sdk/src/ism/EvmIsmModule.ts Show resolved Hide resolved
typescript/cli/src/utils/balances.ts Outdated Show resolved Hide resolved
typescript/sdk/src/token/deploy.ts Show resolved Hide resolved
paulbalaji added a commit that referenced this pull request Jun 21, 2024
@ltyu ltyu requested review from Skunkchain and avious00 as code owners June 26, 2024 21:44
Base automatically changed from cli-2.0 to main June 27, 2024 13:52
@ltyu ltyu removed request for Skunkchain and avious00 June 28, 2024 13:37
@ltyu ltyu enabled auto-merge June 28, 2024 13:40
@ltyu ltyu force-pushed the ezeth-deploy-fixes branch from 18d2af9 to b708f2c Compare June 28, 2024 14:42
@ltyu ltyu added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 4cc9327 Jul 1, 2024
35 of 36 checks passed
@ltyu ltyu deleted the ezeth-deploy-fixes branch July 1, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants